Stable merge 18/7/2022 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ike to change. needs commenting.
…a generic message send object
… pretty cool (also I borrowed your code and put it in the library sorry anna)
…ght clicking a message to quote it
…to interactions
…to interactions
Dice variables
…to interactions
Interactions
Improved accessibility (fewer commands and improved CONTRIBUTING.md)
the-Bruce
requested changes
Jul 18, 2022
There was a problem hiding this comment.
Couple of issues, permission errors have wrong header, and quote rerolling when a quote has been deleted can leave behind a card while still updating the message to say nothing found. Otherwise looks fine as far as I can tell. I could keep testing the roll command for days before fully exploring all edgecases, but it seems stable enough.
…ote errors replace embeds
removed button on quote failure, stop aliasing when alias is blacklisted
the-Bruce
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benji did some crimes again
varkeyword) - think of some cursed dice expressions to test, and also some basic ones to make sure nothing breaks. (Dice variables #133)!aliasand making sure they work as expected. (Alias #134)NOTE this PR updates the regex used to check whether a bot token is valid, because Discord changed the format of bot tokens since the previous merge. It is very likely that your bot token will no longer work, and you'll need to regenerate it. It is also very likely I will have to do this for the actual bot.
OTHER NOTE the update for
discord-haskellhad a funky time on my local copy, but managed to behave after astack clean. So if the build fails, you may have to do that too. (And then maybe leave it for a while because build times bad.)